Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cxl-ui): dashboard feedback tweaks #342

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

HenerHoop
Copy link

  • added a comma before the name in the dashboard header
  • light-card attributes indent fix

https://app.clickup.com/t/86ayff6df

@HenerHoop HenerHoop requested a review from pawelkmpt October 10, 2023 08:06
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 63.48 KB (+0.04% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.65 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 239.73 KB (+0.01% 🔺)

Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

It should be 2 commits though as code fixes are not related to each other (besides being pointed out in on feedback task).

fix(cxl-ui): cxl-light-card ...
fix(cxl-ui): cxl-dashboard-header ...

@HenerHoop HenerHoop force-pushed the hener/fix/dashboard-feedback-tweaks branch from 9f3b941 to b6b142f Compare October 10, 2023 11:00
@HenerHoop HenerHoop requested a review from pawelkmpt October 10, 2023 11:02
@HenerHoop
Copy link
Author

Works well 👍

It should be 2 commits though as code fixes are not related to each other (besides being pointed out in on feedback task).

fix(cxl-ui): cxl-light-card ... fix(cxl-ui): cxl-dashboard-header ...

Created 2 separate commits.

@HenerHoop HenerHoop force-pushed the hener/fix/dashboard-feedback-tweaks branch from 1a10e8c to 2894096 Compare October 10, 2023 11:07
@pawelkmpt pawelkmpt merged commit 3faba5c into master Oct 10, 2023
4 checks passed
@pawelkmpt pawelkmpt deleted the hener/fix/dashboard-feedback-tweaks branch October 10, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants