feat(cxl-ui): improve navigation responsiveness #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
Possibly related: #311 |
pawelkmpt
reviewed
Sep 22, 2023
| @@ -67,77 +101,6 @@ $vaadin-tab-horizontal-padding: 0.75rem; | |||
| margin-left: auto; | |||
| } | |||
|
|
|||
| // Featured course slider | |||
There was a problem hiding this comment.
Why it's suddenly gone? It's not about menu
There was a problem hiding this comment.
It's was in the wrong place, it belongs to cxl-tabs-slider.scss. I had already copied it over, but chose to keep this until we merged the other issue. Now it was making it harder to compare files and find the menu bug, so I cleaned it up.
`.section-header` background appeared again after rebase.
pawelkmpt
force-pushed
the
raphael/fix/navigation/mobile-screens-bug
branch
from
4528f87 to
c67c7a5
Compare
pawelkmpt
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86aybcq9a
The main bug is fixed, but this also includes fixes other user experience issues: