feat(cxl-ui): implement featured-course-card redesign #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
anoblet
reviewed
Sep 21, 2023
| <vaadin-button | ||
| class="cta" | ||
| theme="tertiary" | ||
| @click=${(e) => { |
There was a problem hiding this comment.
We should move away from the technique of using JS to update location. It doesn't allow us to track CTA performance.
https://cxlworld.slack.com/archives/D01JNHHHA1H/p1685977708409489
freudFlintstone
force-pushed
the
raphael/feat/dashboard/featured-course-card-adjust
branch
from
e16283d to
7b97d93
Compare
freudFlintstone
force-pushed
the
raphael/feat/dashboard/featured-course-card-adjust
branch
5 times, most recently
from
23f5157 to
64c91e2
Compare
freudFlintstone
force-pushed
the
raphael/feat/dashboard/featured-course-card-adjust
branch
from
64c91e2 to
0a639dc
Compare
|
Closed because is current shape doesn't look good: https://app.clickup.com/t/86aycyj2q |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86aya2tav