Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cxl-ui): [cxl-marketing-nav] check for empty description elements #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Jan 27, 2023

@github-actions
Copy link

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 30.7 KB (+0.06% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 23.37 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 122.56 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 189.66 KB (+0.01% 🔺)

@paulkirspuu
Copy link

@lkraav
Copy link

lkraav commented Jan 30, 2023

I'm not convinced yet we should be masking this problem coming from PHP layer.

OTOH problem appearance is subtle, and nobody might notice + trimming input surroundings might make sense anyway. Should this also be done in PHP though?

I'll finish debugging PHP this week and make a decision.

@anoblet
Copy link
Collaborator Author

anoblet commented Jan 30, 2023

@paulkirspuu That PR doesn't have this latest code change.

@paulkirspuu
Copy link

I'm not convinced yet we should be masking this problem coming from PHP layer.
OTOH problem appearance is subtle, and nobody might notice + trimming input surroundings might make sense anyway. Should this also be done in PHP though?
I'll finish debugging PHP this week and make a decision.

So, shall we go for PHP or stick with this PR?

@lkraav
Copy link

lkraav commented Feb 14, 2023

So, shall we go for PHP or stick with this PR?

I'm still mid-debugging on that. But let's trim in PHP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants