feat(cxl-ui): [cxl-notification] document renderer function #245
Conversation
size-limit report 📦
|
| @@ -5,6 +5,7 @@ export class CXLNotification extends Notification { | |||
| return 'cxl-notification'; | |||
| } | |||
|
|
|||
| // Provide a default renderer which appends all child nodes to the notification root element. | |||
There was a problem hiding this comment.
Well I can see that from the code, but what's the need?
There was a problem hiding this comment.
Well I can see that from the code, but what's the need?
Maybe this clears it: https://lit.dev/docs/components/shadow-dom/#slots
There was a problem hiding this comment.
Updated to reflect the need for this strategy as well as a reference to the Slack discussion (https://cxlworld.slack.com/archives/C01JABH8AHX/p1662121897793169).
There was a problem hiding this comment.
@anoblet maybe add this too: https://lit.dev/docs/components/shadow-dom/#slots
There was a problem hiding this comment.
@saas786 I can add it you would like. Though we aren't using slots here. There's no slot or slot name="" node. All we are doing is moving direct children to vaadin-notification-card.
There was a problem hiding this comment.
@saas786 I can add it you would like. Though we aren't using slots here. There's no
slotorslot name=""node. All we are doing is moving direct children tovaadin-notification-card.
Not specifically because of slots, but rather DOM rendering point of view, as far as I am aware, child elements won't render otherwise.
anoblet
force-pushed
the
anoblet/feat/cxl-notification
branch
2 times, most recently
from
845ee16 to
1f464a2
Compare
anoblet
force-pushed
the
anoblet/feat/cxl-notification
branch
from
1f464a2 to
8e17f1c
Compare
No description provided.