feat(cxl-lumo-styles): style details elements #432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lkraav
reviewed
Aug 26, 2024
| * @see https://cxlworld.slack.com/archives/C01HXU5GGJG/p1724673491752389 | ||
| * @since 2024.08.26 | ||
| */ | ||
| details { |
There was a problem hiding this comment.
Hmmm, are we not able to build a quick block editor details -> vaadin-details element converter instead, in spirit of https://github.com/conversionxl/cxl-section-block
Itmw, this type of native element CSS patch could go into both apps Customizer.
There was a problem hiding this comment.
Today we'll use ITMW approach but created a task for the future: https://app.clickup.com/t/86b1wx7r9
|
Added styles to customizer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cxlworld.slack.com/archives/C01HXU5GGJG/p1724673491752389