Feature/second-order-runge #277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zebengberg We should probably set the default CoCiP parameters to |
|
@roger-teoh I have another issue out there #199 -- I think it would be good to change all the default parameters at once in the next release! In particular, I think we should set the |
zebengberg
approved these changes
Nov 25, 2024
Comment on lines
224
to
228
| radiative_heating_effects: bool = False | ||
| radiative_heating_effects: bool = True |
There was a problem hiding this comment.
Per Marc's comment, let's change this back to False here, then we'll update in a separate PR.
There was a problem hiding this comment.
Resolved. I have also set second_order_runge to False. We can update in a separate PR.
Comment on lines
174
to
175
| #: CoCiP time integration using the second-order Runge-Kutta scheme | ||
| #: Up until v0.54.3, the time integration step was implemented as a First-order Euler method, |
There was a problem hiding this comment.
Suggested change
| #: CoCiP time integration using the second-order Runge-Kutta scheme | |
| #: Up until v0.54.3, the time integration step was implemented as a First-order Euler method, | |
| #: Perform CoCiP time integration using the second-order Runge-Kutta scheme. | |
| #: If False, a first-order Euler method is used instead. A first-order Euler's method | |
| #: was used exclusively in earlier versions of pycontrails. | |
| #: | |
| #: .. versionadded:: 0.54.4 |
pycontrails/models/cocip/cocip.py
Outdated
| # Second-order Runge-Kutta scheme | ||
| if params["second_order_runge"]: | ||
| # `contrail_2` calculated in first-order Euler method is now used as intermediate values | ||
| contrail_12 = copy.deepcopy(contrail_2) |
There was a problem hiding this comment.
Suggested change
| contrail_12 = copy.deepcopy(contrail_2) | |
| contrail_12 = contrail_2.copy() |
pycontrails/models/cocip/cocip.py
Outdated
| details, see :func:`time_integration_runge_kutta`. | ||
| """ | ||
| # First-order Euler method | ||
| contrail_12 = copy.deepcopy(contrail_1) # Set intermediate values to the initial values |
There was a problem hiding this comment.
Suggested change
| contrail_12 = copy.deepcopy(contrail_1) # Set intermediate values to the initial values | |
| contrail_12 = contrail_1.copy() # Set intermediate values to the initial values |
zebengberg
force-pushed
the
feature/second-order-runge
branch
from
023bcf9 to
50879e6
Compare
zebengberg
force-pushed
the
feature/second-order-runge
branch
from
7471d2a to
b63967a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #XX
Changes
Breaking changes
Features
Fixes
Internals
Tests
make test)Reviewer