Skip to content

fix: 🐛 Add requestOptions to YAML config for mcp #6109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chezsmithy
Copy link
Contributor

@chezsmithy chezsmithy commented Jun 13, 2025

Description

Add request options to mcp server YAML config. Without this in place you can't pass headers for example.

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

Confirmed the following configuration loads headers in:

https://github.com/chezsmithy/continue/blob/16ef20aeca9696f0b751e590671111eafc5fcda7/core/context/mcp/MCPConnection.ts#L352

name: SSE Server
version: 0.0.1
schema: v1
mcpServers:
  - name: sse-server
    type: sse
    url: https://www.example.com
    requestOptions:
      headers: { Authorization: "Bearer ABC", JWT: XXASDASDSAS }

@chezsmithy chezsmithy requested a review from a team as a code owner June 13, 2025 05:15
@chezsmithy chezsmithy requested review from sestinj and removed request for a team June 13, 2025 05:15
Copy link

cubic-dev-ai bot commented Jun 13, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

Copy link

netlify bot commented Jun 13, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 16ef20a
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/684bb3fbf3fb010008124475
😎 Deploy Preview https://deploy-preview-6109--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 13, 2025
Copy link

recurseml bot commented Jun 13, 2025

✨ No issues found! Your code is sparkling clean! ✨

Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change—can we add this to the docs, or do we need to actually implement this in the code?

Edit: I see your link to the code. I think instead of only injecting the headers, we should override the whole fetch function in the same standard way we do throughout the codebase, using @continuedev/fetch

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 16, 2025
@sestinj
Copy link
Contributor

sestinj commented Jun 16, 2025

Edit: I see that this is potentially urgent for you. If you wanted to merge this in and make a follow up PR to address my comments, I would be okay with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants