Skip to content

fix: removed files adding again in edit mode #5204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

uinstinct
Copy link
Contributor

Description

When adding files in the edit mode's add file select box, we are adding the removed files as well.

We need to update the codeToEdit redux state (whenever it changes) with the Combobox's local selectedFiles state

Checklist

  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

before.mp4
after.mp4

Testing instructions

  • open the edit mode
  • select 2-3 files using the add file input and dropdown
  • remove any of the selected files
  • add another different file
  • see that the removed file is added again even though a different file was added

@uinstinct uinstinct requested a review from a team as a code owner April 17, 2025 05:43
@uinstinct uinstinct requested review from tomasz-stefaniak and removed request for a team April 17, 2025 05:43
Copy link

netlify bot commented Apr 17, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit e0a432e
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/6800950e6424a500081a2e49

@sestinj sestinj merged commit 96e5232 into continuedev:main Apr 23, 2025
32 checks passed
@uinstinct uinstinct deleted the fix-removed-items-addfiles branch April 24, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants