fix(config-yaml): prompt caching and reasoning #5202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chezsmithy
force-pushed
the
fix-yaml-reasoning-caching
branch
2 times, most recently
from
3f65c48 to
5bbd42e
Compare
|
@RomneyDa appears that with the latest preview and production builds this problem exists in the yaml config loader so it's no longer possible to activate thinking and caching unless the user reverts back to json. Hope you can check and if possible get this merged soon? |
chezsmithy
force-pushed
the
fix-yaml-reasoning-caching
branch
from
5bbd42e to
2f85661
Compare
chezsmithy
changed the title
chezsmithy
changed the title
This was referenced Apr 20, 2025
|
@RomneyDa and @Patrick-Erichsen curious if we could get a review on this PR and the one also referenced. For those of us who have moved to YAML (I just moved my whole organization) the ability to use prompt caching and reasoning is broken. Thanks! |
Patrick-Erichsen
approved these changes
Apr 28, 2025
|
Apologies for the delay here @chezsmithy , thanks for submitting the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Could also resolve: #4918
Checklist
Screenshots
[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]
Testing instructions
Validated by enabling prompt caching and thinking with the AWS bedrock claude sonet 3.7 model. With this change I am now seeing prompt caching and thinking enabled.