Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove openssl feature flag #940

Merged
merged 1 commit into from
Feb 24, 2025
Merged

refactor: Remove openssl feature flag #940

merged 1 commit into from
Feb 24, 2025

Conversation

cdmurph32
Copy link
Collaborator

Changes in this pull request

Moving cryptography to c2pa-crypto made the openssl and openssl_sign flags defunct.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

Moving cryptography to c2pa-crypto made the `openssl` and `openssl_sign`
flags defunct.
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (91f24a9) to head (ee4ecb8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #940   +/-   ##
=======================================
  Coverage   78.75%   78.76%           
=======================================
  Files         147      147           
  Lines       34965    34963    -2     
=======================================
- Hits        27538    27537    -1     
+ Misses       7427     7426    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks like a very nice code clean up.
I'm curious about how an application will be able to not build with openssl now.
The openssl_sign feature was added for c2pa_min which shows how to build c2pa for signing only using no SSL.

@scouten-adobe scouten-adobe changed the title refactor: Remove openssl features from sdk refactor: Remove openssl feature flag Feb 24, 2025
@cdmurph32
Copy link
Collaborator Author

Thanks, this looks like a very nice code clean up. I'm curious about how an application will be able to not build with openssl now. The openssl_sign feature was added for c2pa_min which shows how to build c2pa for signing only using no SSL.

I think they would add c2pa-crypto as an explicit dependency with the feature rust_native_crypto. I think that has been true since @scouten-adobe moved the crypto to its own crate.

@cdmurph32 cdmurph32 merged commit 5a6a8bb into main Feb 24, 2025
33 checks passed
@cdmurph32 cdmurph32 deleted the rm_openssl_feature branch February 24, 2025 20:00
@scouten-adobe scouten-adobe mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants