fix: Use older version of x509-certificate for wasm32-unknown #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #934 +/- ##
==========================================
+ Coverage 78.93% 78.94% +0.01%
==========================================
Files 147 147
Lines 34842 34842
==========================================
+ Hits 27503 27507 +4
+ Misses 7339 7335 -4 ☔ View full report in Codecov by Sentry. |
x509-certificate v0.22.0 uses a newer version of ring (0.17.5) which cannot be built by Xcode on Mac Silicon for wasm32-unknown-unknown.
cdmurph32
force-pushed
the
wasm_browser_x509
branch
from
9398a97 to
b7f14ec
Compare
gpeacock
approved these changes
Feb 19, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
x509-certificate v0.22.0 uses a newer version of ring (0.17.5) which cannot be built by Xcode on Mac Silicon for wasm32-unknown-unknown.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.