-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds validation_state to the json reports from the Reader #930
Conversation
chore: remove Store and ManifestStore from the non-v1 public SDK refactoring and code removal
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
==========================================
- Coverage 78.94% 78.74% -0.21%
==========================================
Files 147 147
Lines 34842 34965 +123
==========================================
+ Hits 27507 27534 +27
- Misses 7335 7431 +96 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of an abundacne of caution, I would suggest to verify this does not break c2pa-c and c2pa-python before emrging it (breaking the builds and/or the tests).
And even if it breaks something, then we'd know what to fix too.
I build and ran tests using this branch with c2pa-c and c2pa-python, everything built without errors and all tests passed. |
This is also a cleanup of the new API, removing ManifestStore, ManifestStoreReport, and Store from the public API unless the v1_api feature is used.
These are steps toward a version 1.0 SDK.