Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct byte label for GIF Plain Text Extension #864

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

ok-nick
Copy link
Contributor

@ok-nick ok-nick commented Jan 21, 2025

Changes in this pull request

Noticed that the plain text extension is being matched under 0x21 (the extension introducer) instead of 0x01 (the plain text extension label).

2025-01-20 at 20 50 35

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@gpeacock gpeacock self-assigned this Feb 15, 2025
@gpeacock gpeacock added bug Something isn't working accepted labels Feb 15, 2025
@gpeacock gpeacock self-requested a review February 15, 2025 00:18
Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nick!

@gpeacock gpeacock merged commit 9b725ba into contentauth:main Feb 15, 2025
14 of 15 checks passed
This was referenced Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants