Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SVG thumbnails with a fix to the ingredient thumbnail format detection #722

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

brogdonm
Copy link
Contributor

Changes in this pull request

Give a narrative description of what has been changed.

This adds the ability to correctly list an SVG as a thumbnail type for an asset. This would be useful in the font scenario, where using an SVG representation of the font is more efficient.

Additionally, it was noted that the logic in the Ingredient::update_validation_status and the thumbnail_from_assertion calls were incorrectly assuming the extension would work for a format!("image/{}", ext) call. This was fine for jpg and/or png, but for svg it should be image/svg+xml, so the utils::extension_to_mime method was used in its stead.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant