Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GIF support #489

Merged
merged 34 commits into from
Jul 16, 2024
Merged

Add GIF support #489

merged 34 commits into from
Jul 16, 2024

Conversation

ok-nick
Copy link
Contributor

@ok-nick ok-nick commented Jun 21, 2024 •
edited
Loading

Changes in this pull request

Adds GIF support.

Related Issues

WIP Priorities

  • Parse entire GIF past pre-image-data block extensions
    • Enables box hashing
    • Completes XMP support (need to search pre and post block extensions)
  • Block extension parser should be incremental (via iterator)
    • It should also iterate blocks past pre-image-data as described above
  • Data hash location for XMP block
  • Add unit tests
    • Composed manifest refs
    • Asset patches
    • Data hash locations
    • Box hash locations
    • Remote refs

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@ok-nick ok-nick added the enhancement New feature or request label Jun 21, 2024
@ok-nick ok-nick linked an issue Jun 21, 2024 that may be closed by this pull request
Add GIF support #476
Closed
@ok-nick ok-nick removed a link to an issue Jul 1, 2024
Add GIF support #476
Closed
@ok-nick ok-nick linked an issue Jul 1, 2024 that may be closed by this pull request
Add GIF support #476
Closed
@ok-nick ok-nick marked this pull request as ready for review July 1, 2024 20:34
@mauricefisher64
Copy link
Collaborator

Looks good. Just address the build issues and I can approve.

@ok-nick
Copy link
Contributor Author

ok-nick commented Jul 8, 2024

@mauricefisher64 Build issue is caused by an update in nightly toolchain, fixed in #498

@ok-nick ok-nick mentioned this pull request Jul 12, 2024
Open
mauricefisher64
mauricefisher64 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@mauricefisher64 mauricefisher64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gpeacock gpeacock merged commit 1d870e7 into main Jul 16, 2024
22 checks passed
@gpeacock gpeacock deleted the ok-nick/gif branch July 16, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauricefisher64 mauricefisher64 mauricefisher64 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GIF support
3 participants
@ok-nick @mauricefisher64 @gpeacock