fix: Don't take ownership of data when using AsyncSigner; use a reference instead
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mauricefisher64 @gpeacock The vulnerability failure appears after merging the latest |
duggaraju
reviewed
Jun 30, 2024
scouten-adobe
changed the title
AsyncSigner; use a reference insteadAsyncSigner; use a reference instead
|
I'll try to take a look at this tomorrow and fix up where I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Give a narrative description of what has been changed.
During use of the
AsyncSignertrait, we noticed thesignmethod has a different signature than the simpleSignertrait. The current implementation passed ownership of the data to the signer instead of passing a reference.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.