-
Notifications
You must be signed in to change notification settings - Fork 30
Some QoL changes for the build process #16
base: master
Are you sure you want to change the base?
Changes from all commits
b5df574
4480944
02b0f0e
2272deb
af6994f
8a3ea6b
0e05b56
161389d
ed64aef
0c24378
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,11 @@ MYSQL_USER=contenta | |
MYSQL_PASSWORD=contenta | ||
MYSQL_ALLOW_EMPTY_PASSWORD=yes | ||
MYSQL_ROOT_PASSWORD=root | ||
|
||
HOSTNAME=contenta.local | ||
HOSTIP=192.168.1.1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the final goal would be to have a network set up instead of fixing an IP? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ya, that would likely be a better idea. I was just putting this in as I didn't want it in the docker-compose.yml. Again, the more generic, the better, I suppose. |
||
|
||
HOST_MYSQL_PORT=3336 | ||
HOST_PHP_PORT=9009 | ||
HOST_HTTP_PORT=8888 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ports maybe good to have by default but why don't use the default ports? I'm guessing adding a .env.defaults with all this would be better instead and add .env to the gitignore There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ya, the defaults would be a good idea to use as a common base, I put those in as I wanted to show an example of slightly modified ports. But I'm fine with whatever. |
||
HOST_HTTPS_PORT=4443 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,8 +68,9 @@ RUN mkdir -p /var/www && \ | |
chmod +x /usr/local/bin/docker-entrypoint && \ | ||
chmod +x /usr/local/bin/init-drupal | ||
|
||
ARG CMS_VERSION=8.x-1.x | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. CONTENTA_VERSION? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ya, that's the contenta_version. Obviously, the base here. I added the CMS_VERSION as this is how it was identified somewhere in the contenta build. So, just took a cue off them. |
||
RUN cd /usr/local/src && \ | ||
git clone https://github.com/contentacms/contenta_jsonapi && \ | ||
git clone https://github.com/contentacms/contenta_jsonapi --branch ${CMS_VERSION} && \ | ||
cd /usr/local/src/contenta_jsonapi && \ | ||
composer create-project contentacms/contenta-jsonapi-project /var/www --stability dev --no-interaction && \ | ||
cd /var/www && \ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,4 +4,6 @@ ep /etc/php.ini | |
ep /etc/php-fpm.conf | ||
ep /etc/php-fpm.d/* | ||
|
||
[ ! -e /run/php-fpm ] && mkdir -p /run/php-fpm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this needed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I noticed in one of the forks, this was a problem for some, where the fpm workers weren't starting due to a missing path. I put it in just as a precaution. I've also noticed this setup in docker4drupal, so it must be a common fix. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this solves the issue i run into, where its missing that folder and errors out thus php container never runs, seems like this issue was reported here: #17 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
exec "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that for decoupled development, it's maybe good having localhost as the host so things like service workers and so on don't get blocked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a really good idea, as long as its on a port I guess. We really don't want to clobber other localhost apps that might be running on the host.