Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for translation handling and support arbitrary routing #634

Merged
merged 5 commits into from
May 15, 2024

Conversation

zonky2
Copy link
Contributor

@zonky2 zonky2 commented May 15, 2024

Description

  • Translate operation button labels and descriptions correctly including fallback to old style translation files
  • Translate global operation button labels and descriptions correctly including fallback to old style translation files
  • Correct translation key for editAll button
  • Fix URL generating in CopyHandler
  • Translate property names in SelectAllHandler correctly
  • Translate property names in parent view header correctly
  • Change various translation keys from .0 => .label etc.
  • Fix URL generating in ClipboardController
  • Really check permission for excluded fields instead of returning always false
  • Handle translations in WidgetBuilder
  • Support arbitrary routes in ViewHelpers::redirectHome
  • Update referers in session for routes with attribute _dcg_referer_update (As Contao does for DC_Table)
  • Translate properties in panel elements.

Checklist

  • Read and understood the CONTRIBUTING guidelines
  • Created tests, if possible
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself to the @authors in touched PHP files
  • Checked the changes with phpcq and introduced no new issues

We can use `.label` ans `.description` instead of `.0` and `.1`
@zonky2 zonky2 requested a review from discordier May 15, 2024 14:26
@zonky2 zonky2 added this to the 2.3.10 milestone May 15, 2024
@zonky2 zonky2 self-assigned this May 15, 2024
@zonky2 zonky2 changed the title change translation keys for defaul Update for translation handling and support arbitrary routing May 15, 2024
- Translate operation button labels and descriptions correctly including fallback to old style translation files
- Translate global operation button labels and descriptions correctly including fallback to old style translation files
- Correct translation key for editAll button
- Fix URL generating in CopyHandler
- Translate property names in SelectAllHandler correctly
- Translate property names in parent view header correctly
- Change various translation keys from .0 => .label etc.
- Fix URL generating in ClipboardController
- Really check permission for excluded fields instead of returning always false
- Handle translations in WidgetBuilder
- Support arbitrary routes in `ViewHelpers::redirectHome`
- Update referers in session for routes with attribute `_dcg_referer_update` (As Contao does for DC_Table)
- Translate properties in panel elements
@zonky2 zonky2 force-pushed the hotfix/change_transpation_keys_for_mm branch from fcde601 to 5ace001 Compare May 15, 2024 15:27
@zonky2 zonky2 changed the base branch from master to hotfix/2.3.10 May 15, 2024 15:52
@zonky2 zonky2 merged commit e703436 into hotfix/2.3.10 May 15, 2024
4 checks passed
@zonky2 zonky2 deleted the hotfix/change_transpation_keys_for_mm branch May 16, 2024 07:08
@MarkejN MarkejN mentioned this pull request Jun 24, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants