Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translation button renderer #626

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fix translation button renderer #626

merged 1 commit into from
Jan 22, 2024

Conversation

zonky2
Copy link
Contributor

@zonky2 zonky2 commented Dec 13, 2023

Fix translation button renderer

@zonky2 zonky2 self-assigned this Dec 13, 2023
@zonky2 zonky2 added the bug label Dec 13, 2023
@zonky2 zonky2 added this to the 2.3.5 milestone Dec 13, 2023
@discordier
Copy link
Member

While this fixes the load problem, we should also change the remaining translations.

The legacy translator is causing way too high file I/O due to loading the translations over and over again.

@zonky2 zonky2 modified the milestones: 2.3.5, 2.3.6 Dec 22, 2023
@zonky2 zonky2 force-pushed the hotfix/fix_translations_at_button_renderer branch from 7eb9e99 to a53562f Compare December 23, 2023 15:38
@zonky2 zonky2 force-pushed the hotfix/fix_translations_at_button_renderer branch 10 times, most recently from 2ede4e4 to 545ba76 Compare January 12, 2024 17:33
@zonky2 zonky2 force-pushed the hotfix/fix_translations_at_button_renderer branch from 545ba76 to b66b02d Compare January 15, 2024 21:18
@zonky2 zonky2 force-pushed the hotfix/fix_translations_at_button_renderer branch from b66b02d to 94087cd Compare January 15, 2024 22:29
stefanheimes added a commit that referenced this pull request Jan 22, 2024
@stefanheimes
Merge tag '2.3.6'
bc938ef 
Hotfix release 2.3.6

- Fix translation button renderer #626
- Fix label-callback at treepicker-popup #628 / #627
@stefanheimes stefanheimes merged commit 55ee65e into master Jan 22, 2024
4 checks passed
@discordier discordier deleted the hotfix/fix_translations_at_button_renderer branch March 6, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discordier discordier Awaiting requested review from discordier

Assignees

@zonky2 zonky2

Labels
bug
Projects
None yet
Milestone
2.3.6
Development

Successfully merging this pull request may close these issues.
4 participants
@zonky2 @discordier @stefanheimes @e-spin