Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix incorrect actions config #1872

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix(ci): fix incorrect actions config #1872

merged 1 commit into from
Dec 8, 2023

Conversation

piksel
Copy link
Member

@piksel piksel commented Dec 8, 2023

This fixes three problems:

  • setup-go in the dev-release tried to install go v1.2 instead of v1.20, since it's parsed as a number
  • when setting the dev version, not enough commits where fetched to feed git describe
  • release builds were triggered on release creation instead of tag creation and with a incorrect tag selector

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2576ba3) 70.55% compared to head (e33d48e) 70.55%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1872   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files          26       26           
  Lines        2493     2493           
=======================================
  Hits         1759     1759           
  Misses        633      633           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piksel piksel merged commit 2d7735f into main Dec 8, 2023
12 checks passed
@piksel piksel deleted the fix/ci-build branch December 8, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant