Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix json syntax error in .all-contributorsrc #1867

Merged

Conversation

PeterDaveHello
Copy link
Contributor

@PeterDaveHello PeterDaveHello commented Dec 2, 2023

🐛 This bug seems to be the reason for the "all contributors unparseable json" result in the readme as below:

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on opening your first pull request! We'll get back to you as soon as possible. In the meantime, please make sure you've updated the documentation to reflect your changes and have added test automation as needed. Thanks! 🙏🏼

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2576ba3) 70.55% compared to head (9b01e3e) 70.55%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1867   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files          26       26           
  Lines        2493     2493           
=======================================
  Hits         1759     1759           
  Misses        633      633           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piksel piksel changed the title Fix json syntax error in .all-contributorsrc chore: fix json syntax error in .all-contributorsrc Dec 2, 2023
@piksel piksel merged commit 01fd38b into containrrr:main Dec 2, 2023
11 checks passed
@PeterDaveHello PeterDaveHello deleted the fix.all-contributorsrc branch December 2, 2023 15:38
Copy link
Contributor

@piksel

We had trouble processing your request. Please try again later.

@piksel
Copy link
Member

piksel commented Dec 8, 2023

@all-contributors please add @PeterDaveHello for bug

Copy link
Contributor

@piksel

We had trouble processing your request. Please try again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants