Skip to content
This repository has been archived by the owner on Apr 3, 2018. It is now read-only.

Check podID and containerID function arguments #163

Merged
merged 6 commits into from
Apr 12, 2017
Merged

Check podID and containerID function arguments #163

merged 6 commits into from
Apr 12, 2017

Commits on Apr 12, 2017

  1. network: Add argument checks. 

    Return error if argument checks fail.

Signed-off-by: James O. D. Hunt <[email protected]>
    @jodh-intel
    jodh-intel committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    73f5dff View commit details
    Browse the repository at this point in the history

  2. errors: Add additional standard errors. 

    Added additional variables for standard error conditions.

Signed-off-by: James O. D. Hunt <[email protected]>
    @jodh-intel
    jodh-intel committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    bb8fe0d View commit details
    Browse the repository at this point in the history

  3. arguments: Expand empty podID and containerID as early as possible. 

    Previously, blank containerID was handled by ContainerConfig.valid() and
a blank podID was handled by PodConfig.valid().

However, this meant function arguments could not be checked reliably
(since some functions accepted blank values, knowning that they would be
expanded by a lower level). The behaviour was also rather confusing
since valid() connotes isValid(), not makeValid().

This change Ensures that both podID and containerID are set at the
highest level (in virtc) which will allow all lower-level functions to
assert these values are non-blank in future. It also adds an explicit
"--id=" for "pod create".

Signed-off-by: James O. D. Hunt <[email protected]>
    @jodh-intel
    jodh-intel committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    9f78c02 View commit details
    Browse the repository at this point in the history

  4. general: Add explicit checks on all possible function arguments. 

    Where possible, standard errors are used.

Note that a few parameter names have changed slightly to ensure
the returned standard errors make sense.

Signed-off-by: James O. D. Hunt <[email protected]>
    @jodh-intel
    jodh-intel committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    17726a8 View commit details
    Browse the repository at this point in the history

  5. filesystem: Improve comments on podResource. 

    Explain which podResource types relate only to pods.

Signed-off-by: James O. D. Hunt <[email protected]>
    @jodh-intel
    jodh-intel committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    f74bd13 View commit details
    Browse the repository at this point in the history

  6. virtc: Explain the "--id=" is set automatically by default. 

    Updated usage to show that if the user does not specify a container name
using "--id=", one will be chosen automatically.

Signed-off-by: James O. D. Hunt <[email protected]>
    @jodh-intel
    jodh-intel committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    ac92c3e View commit details
    Browse the repository at this point in the history