-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ubuntu-toolbox version 24.10, removed 23.10 (eol) #1565
Open
davidscholberg
wants to merge
1
commit into
containers:main
Choose a base branch
from
davidscholberg:add-ubuntu-24.10
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7
−12
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
FROM docker.io/library/ubuntu:23.10 | ||
FROM docker.io/library/ubuntu:24.10 | ||
|
||
LABEL com.github.containers.toolbox="true" \ | ||
name="ubuntu-toolbox" \ | ||
version="23.10" \ | ||
version="24.10" \ | ||
usage="This image is meant to be used with the toolbox command" \ | ||
summary="Base image for creating Ubuntu Toolbx containers" \ | ||
maintainer="Ievgen Popovych <[email protected]>" | ||
|
@@ -11,19 +11,14 @@ LABEL com.github.containers.toolbox="true" \ | |
# Remove docker-gzip-indexes to help with "command-not-found" | ||
RUN rm /etc/apt/apt.conf.d/docker-gzip-indexes /etc/apt/apt.conf.d/docker-no-languages | ||
|
||
# Enable myhostname nss plugin for clean hostname resolution without patching | ||
# hosts (at least for sudo), add it right after 'files' entry. We expect that | ||
# this entry is not present yet. Do this early so that package postinst (which | ||
# adds it too late in the order) skips this step | ||
RUN sed -Ei 's/^(hosts:.*)(\<files\>)\s*(.*)/\1\2 myhostname \3/' /etc/nsswitch.conf | ||
|
||
# Restore documentation but do not upgrade all packages | ||
# Install ubuntu-minimal & ubuntu-standard | ||
# Install extra packages as well as libnss-myhostname | ||
COPY extra-packages / | ||
RUN sed -Ei '/apt-get (update|upgrade)/s/^/#/' /usr/local/sbin/unminimize && \ | ||
apt-get update && \ | ||
yes | /usr/local/sbin/unminimize && \ | ||
RUN apt-get update && \ | ||
DEBIAN_FRONTEND=noninteractive apt-get -y install unminimize && \ | ||
sed -Ei '/apt-get (update|upgrade)/s/^/#/' /usr/bin/unminimize && \ | ||
yes | /usr/bin/unminimize && \ | ||
DEBIAN_FRONTEND=noninteractive apt-get -y install \ | ||
ubuntu-minimal ubuntu-standard \ | ||
libnss-myhostname \ | ||
|
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this as
libnss-myhostname
now does the actual configuration for us.