Skip to content

Commit

Permalink
test/system: Remove unnecessary --assumeyes
Browse files Browse the repository at this point in the history
It shouldn't be necessary to use the --assumeyes option when creating a
Toolbx container, if the corresponding image is already present in the
local containers/storage image store.  It's harmful to test it with the
option, even when it shouldn't be needed, because it's off by default
and most users won't enable it.

Therefore, it's better to test the most common scenario that most users
will encounter.

#1536
  • Loading branch information
debarshiray committed Sep 5, 2024
1 parent 983beb1 commit c6a1de3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/system/101-create.bats
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@ teardown() {
@test "create: With a custom name (using option --container)" {
pull_default_image

run "$TOOLBX" --assumeyes create --container "custom-containerName"
run "$TOOLBX" create --container "custom-containerName"

assert_success
}

@test "create: With a custom image and name (using option --container)" {
pull_distro_image fedora 34

run "$TOOLBX" --assumeyes create --container "fedora34" --image fedora-toolbox:34
run "$TOOLBX" create --container "fedora34" --image fedora-toolbox:34

assert_success
}
Expand Down

0 comments on commit c6a1de3

Please sign in to comment.