Validate the bind-propagation option to --mount
#24124
Open
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM but test not happy. |
Luap99
reviewed
Oct 2, 2024
pkg/specgenutil/volumes.go
Outdated
| case "shared", "rshared", "private", "rprivate", "slave", "rslave", "unbindable", "runbindable": | ||
| // Do nothing, sane value | ||
| default: | ||
| return nil, fmt.Errorf("invalid value %q for bind-propagation mount option", value) |
There was a problem hiding this comment.
not blocking but I would just log arg and then remove the for bind-propagation part.
test/e2e/run_volume_test.go
Outdated
| @@ -122,6 +122,10 @@ var _ = Describe("Podman run with volumes", func() { | |||
| session.WaitWithDefaultTimeout() | |||
| Expect(session).To(ExitWithError(125, `"notmpcopyup" option not supported for "bind" mount types`)) | |||
|
|
|||
| session = podmanTest.Podman([]string{"run", "--rm", "--mount", "type=bind,src=/tmp,target=/tmp,bind_propagation=fake", ALPINE, "true"}) | |||
There was a problem hiding this comment.
s/bind_propagation/bind-propagation
Similar to github.com/containers/buildah/pull/5761 but not security critical as Podman does not have an expectation that mounts are scoped (the ability to write a --mount option is already the ability to mount arbitrary content into the container so sneaking arbitrary options into the mount doesn't have security implications). Still, bad practice to let users inject anything into the mount command line so let's not do that. Signed-off-by: Matt Heon <[email protected]>
mheon
force-pushed
the
validate_bind_propagation
branch
from
d8f01c7
to
2a263d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to github.com/containers/buildah/pull/5761 but not security critical as Podman does not have an expectation that mounts are scoped (the ability to write a --mount option is already the ability to mount arbitrary content into the container so sneaking arbitrary options into the mount doesn't have security implications). Still, bad practice to let users inject anything into the mount command line so let's not do that.
Does this PR introduce a user-facing change?