vendor: drop override for github.com/opencontainers/runc

[giuseppe]

podman builds fine with the latest runc, so we can drop the override.

Closes: #19795

Does this PR introduce a user-facing change?

None

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [giuseppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrothberg]

LGTM

[giuseppe]

shurg, we are pulling in a huge new dependency (github.com/cilium/ebpf).

As usual, I forgot to run git add vendor before pushing the first version of the patch

[vrothberg]

I think there's still some vendor-dependency fart. The main branch of runc doesn't require cilium anymore. But trying to vendor that will revert many other dependencies.
$ go mod edit -replace github.com/opencontainers/runc=github.com/opencontainers/runc@24ae5c258c41a122f1b96319c087337bac7b308a moves it to the latest commit and doesn't pull in cilium ... but it still replaces.

[giuseppe]

I still see cilium in the latest revision: https://github.com/opencontainers/runc/blob/main/go.mod#L7

and I get the same bloat locally: it is 59137488 vs 58094336

@kolyshkin do you think it would make sense to have a build tag to drop ebpf?

[vrothberg]

I noticed that common is also replacing runc. I guess we need to start there.

[giuseppe]

opened a PR for runc to allow disabling eBPF support: opencontainers/runc#4005

let's see if that breaks any test

[giuseppe]

@kolyshkin I am using the latest HEAD version here, still the binary size grew by 836320 bytes

that is why the package is referenced by:

runc/libcontainer/cgroups/fs/devices.go:9:     cgroupdevices "github.com/opencontainers/runc/libcontainer/cgroups/devices"

[giuseppe]

temporary version bump until there is a new runc version: #19854

[vrothberg]

temporary version bump until there is a new runc version: #19854

@cyphar, do you have another runc version bump scheduled?

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[giuseppe]

rebased and testing: containers/common#1633

[vrothberg]

The system failures look consistent

[giuseppe]

runc is still bloated, the last version didn't fix the dependency issue with EPBF (reported here: opencontainers/runc#4005), I'll close this PR for now