Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Some distros do not default to docker.io for shortname searches #19759

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Aug 26, 2023

Fixes: #18910

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2023
@mheon
Copy link
Member

mheon commented Aug 28, 2023

LGTM, but CI is very angry. I restarted tests, but we may need a restart.

@mheon
Copy link
Member

mheon commented Aug 28, 2023

Sorry, a rebase, not a restart.

@baude
Copy link
Member

baude commented Aug 28, 2023

needs rebase i think

@TomSweeneyRedHat
Copy link
Member

Changes LGTM
Tests are still very red though.

@vrothberg
Copy link
Member

Tests are still very red though.

All infra flakes. We can restart those.

@vrothberg
Copy link
Member

Ah, "The referenced image resource cannot be found" ... it really needs a rebase

@edsantiago edsantiago changed the title [CI:DOCS] Some distros do not defautl to docker.io for shortname searches [CI:DOCS] Some distros do not default to docker.io for shortname searches Aug 30, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 31, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2023
@rhatdan
Copy link
Member Author

rhatdan commented Sep 6, 2023

Yikes I accidently overrode this

@rhatdan rhatdan closed this Sep 6, 2023
@TomSweeneyRedHat
Copy link
Member

LGTM
and happy green test buttons.

@rhatdan rhatdan added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit c11ac80 into containers:main Sep 6, 2023
37 checks passed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading search command in documentation's introductory section
6 participants