Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:BUILD] Podman FCOS image from main #19477
[CI:BUILD] Podman FCOS image from main #19477
Changes from all commits
50cd072
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 575 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L575
Check warning on line 575 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L575
Check warning on line 575 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L575
Check warning on line 575 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L575
Check warning on line 575 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L575
Check warning on line 575 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L575
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
Check warning on line 984 in .cirrus.yml
Cirrus CI / Build Parsing Results
.cirrus.yml#L984
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: I don't really see a need for
next
orpodman-next
, sincelatest
will be effectively the exact same thing.Also Minor: Using a "naked" commit sha as a tag makes me slightly uncomfortable. It makes sense as an annotation or label for sure. But any lay-person looking at an image named "fcos" on quay, will likely have no clue what the sha belongs to. I'm not 100% on what the intended use of this image is, but I would think something like the full podman version would be more helpful.
Since you're setting an expiration of these tags, it's fine to fixup this stuff later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, now that I think of it, someone browsing:
quay.io/podman/fcos
and looking at the taglatest
would assume it's stable, like for example:fedora:latest
points to fedora's latest release. Maybe latest should be removed. If I gotta choose between next and podman-next, I'll choose podman-next.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, `podman-next' is way more meaningful than 'latest'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor-nit: There's no need to do the
|
line-wrapping thing for a single line.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's what the redhat-action doc used, so I used the same. I can remove it in followup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a reminder: It would be really great to have some kind of notification if the job fails. Basically nobody pays any attention to the 'Actions' tab of the repo. and it seems important to know if the build fails for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remind me, do you know of a failure notification mechanism in GHA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only way I know to do this is like https://github.com/containers/podman/blob/main/.github/workflows/discussion_lock.yml#L57-L68 but maybe there's a way to send an in-app notification? I never looked into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello, we wanted to have a specific tag pushed on the registry (in addition to a rolling tag like
latest
,next
, whatever but I don't see expiration usingquay.expires-after
LABEL being set ?https://access.redhat.com/documentation/fr-fr/red_hat_quay/3/html/use_red_hat_quay/working_with_tags#setting_tag_expiration_from_a_dockerfile
images won't expire ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would the tag be? The short commit ID maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack, i'll add those too, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I didn't know about the
quay.expires-after
mechanism, assumed you had to set that via their API. Neat! Should that be something like +6months or something else?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
short git id would be fine, about expiry time I have no strong opinion. but I'm not sure I will try to get development versions before a major release.
So if you release every 3 months then it might be the good window
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm setting expiry to 30d for now. Regarding tags, looks like those can be handled in the GHA file.