Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.12 support and remove python xdg #401

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

inknos
Copy link
Contributor

@inknos inknos commented Jun 20, 2024

related to #397

Copy link

We were not able to find or create Copr project packit/containers-podman-py-401 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=containers-podman-py-401 chroots=['centos-stream-9-x86_64', 'centos-stream-10-x86_64']): Response is not in JSON format, there is probably a bug in the API code.

Please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@lsm5
Copy link
Member

lsm5 commented Jun 24, 2024

/packit build

@lsm5 lsm5 linked an issue Jun 24, 2024 that may be closed by this pull request
@lsm5
Copy link
Member

lsm5 commented Jun 24, 2024

packit builds are happy, that's good.

@inknos i think it would be nice to get this in before we cut 5.1 release. wdyt? cc @jwhonce

@rhatdan
Copy link
Member

rhatdan commented Jun 24, 2024

LGTM although linter is not happy.

Python xdg is used in few parts of the code and its lack of support
could introduce vulnerabilities in the codebase.

Signed-off-by: Nicola Sella <[email protected]>
Signed-off-by: Nicola Sella <[email protected]>
@inknos
Copy link
Contributor Author

inknos commented Jun 24, 2024

sorry for the noise. my local env is faulty and does not have the same results that github for black and pylint. I fixed the linter now

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inknos, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e882700 into containers:main Jun 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for python 3.12+ ?
4 participants