Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rich dependency to setup.cfg #351

Closed
wants to merge 1 commit into from

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Nov 29, 2023

Fixes #350

@jwhonce jwhonce added the bug Something isn't working label Nov 29, 2023
@jwhonce jwhonce self-assigned this Nov 29, 2023
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwhonce jwhonce requested review from baude, umohnani8 and ashley-cui and removed request for ashley-cui November 29, 2023 21:30
@rhatdan
Copy link
Member

rhatdan commented Nov 30, 2023

LGTM

@rhatdan
Copy link
Member

rhatdan commented Nov 30, 2023

@umohnani8 PTAL

@jwhonce
Copy link
Member Author

jwhonce commented Nov 30, 2023

Closed in favor of #349

@jwhonce jwhonce closed this Nov 30, 2023
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Apr 8, 2024
* Update kolla-ansible from branch 'master'
  to cc8658edb3c9ff975ce90ebbebfe1bf38a307f11
  - Merge "Revert "podman: install "rich" dependency""
  - Revert "podman: install "rich" dependency"
    
    This reverts commit 0b1a59dd8cc2b402b5a0ad9b02144edd1daf40ca.
    
    Reason for revert: Upstream Fix available at containers/podman-py#351
    
    Change-Id: Iadb74ffb5a747bd16e6acebd6a9c22b3b7198fd0
openstack-mirroring pushed a commit to openstack/kolla-ansible that referenced this pull request Apr 8, 2024
This reverts commit 0b1a59d.

Reason for revert: Upstream Fix available at containers/podman-py#351

Change-Id: Iadb74ffb5a747bd16e6acebd6a9c22b3b7198fd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installation is missing the "rich" dependency in setup.cfg|pyproject.toml?
2 participants