Fix up docs and format issues #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Urvashi Mohnani <[email protected]>
Fix the command to build the docs to ensure that they are created at the right location so that they show up in readthedocs. Signed-off-by: Urvashi Mohnani <[email protected]>
umohnani8
force-pushed
the
docfixes-2
branch
3 times, most recently
from
f712daf
to
9ff429b
Compare
1 task
umohnani8
force-pushed
the
docfixes-2
branch
2 times, most recently
from
35aa8a9
to
8675266
Compare
|
LGTM |
umohnani8
force-pushed
the
docfixes-2
branch
5 times, most recently
from
259674a
to
c053f7e
Compare
umohnani8
commented
Nov 7, 2023
This is used towork around some invalid-name issue and cyclic import issue which seems to be a bug in pylint Signed-off-by: Urvashi Mohnani <[email protected]>
cevich
approved these changes
Nov 7, 2023
|
@umohnani8 LGTM. Do you wanna squash commits or did you intend for them to be 3 separate commits? |
|
I was planning on leaving them as 3 separate commits @lsm5 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, lsm5, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up some format issues and also fix the command to build the docs so that is built accurately and in the right location for it to show up in readthedocs.