Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes the possibility to use the 'listTags' parameter in image search endpoint #295

Merged
merged 3 commits into from
Jul 2, 2023

Conversation

apozsuse
Copy link
Contributor

From Podman 4.0, the endpoint for image search (doc ) includes the possibility to include a listTags (bool) parameter that allows the user get all the available tags for a specific image in the registry.

Similar suggestion (and solution) was raised in Issue 264.

The parameter is only included in the API request if the user includes it in the kwargs parameters for the function, so this change should not break anything if the user is interacting with some podman instance < 4.0.

Unit and integration tests have been included in the PR.

Signed-off-by: apozsuse [email protected]

search operation.

From Podman 4.0, the endpoint for image search allows to include a
`listTags` (bool) parameter that allows the user get all the available
tags for a specific image in the repo.

The parameter is only included in the API request if the user includes
it in the kwargs parameters for the function.

Signed-off-by: apozsuse <[email protected]>
Signed-off-by: Andres Pozo Munoz <[email protected]>
Signed-off-by: Andres Pozo Munoz <[email protected]>
@apozsuse apozsuse force-pushed the include_listTags_param_in_search branch from bea6652 to cfb7f99 Compare June 27, 2023 13:33
Copy link
Member

@jwhonce jwhonce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apozsuse, jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Jul 2, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 2, 2023
@rhatdan rhatdan merged commit 99e5147 into containers:main Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants