-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep main branch version ahead of release branches #289
Conversation
I'm cleaning up packit stuff in #288 and noticed main version is older than what's released. |
@lsm5 does this need a rebase? |
yes it does. I'll do it now. |
@lsm5 Still a draft? |
I'll remove draft status once builds pass. |
@umohnani8 @rhatdan Ready to go |
LGTM |
I think let's add |
works for me. I can add that to the PR and we'll see what blows up :) |
@lsm5 Reminder |
argh, got distracted. Let me fix this one. |
45bdf33
to
9a92df7
Compare
@umohnani8 @rhatdan ping any idea whatsup with the test:
Is it that |
@umohnani8 @rhatdan Looks like |
Also, I think sometime ago there was some blocker that prevented us from specifying the version only once. Has that issue been revisited? |
Use `-dev` to denote development branch. `LIBPOD_URL` in `poodman/tests/__init__.py` doesn't work with `-dev`, so we only use `vX.Y.Z`. Signed-off-by: Lokesh Mandvekar <[email protected]>
Squashed commits. Also updated commit message. PTAL |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Use
-dev
to denote development branch.LIBPOD_URL
inpoodman/tests/__init__.py
doesn't work with-dev
, sowe only use
vX.Y.Z
.