Fix the ability to run containers #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jonathanunderwood The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jonathanunderwood
force-pushed
the
fixups
branch
from
e0d7178
to
b7cd8d0
Compare
The Podman REST wait endpoint returns a JSON encoded integer, whereas
the Container.wait() function was expecting a JSON
object with "Error" and "Status Code" keys (which actually corresponds
to the response from the "Podman compat" legacy API). So, we fix that
in the Container.wait() method, and in the consuming Container.run()
method.
See:
https://docs.podman.io/en/latest/_static/api.html#tag/containers/operation/ContainerWaitLibpod
Signed-off-by: Jonathan G. Underwood <[email protected]>
This is a cosmetic clarification. Signed-off-by: Jonathan G. Underwood <[email protected]>
Signed-off-by: Jonathan G. Underwood <[email protected]>
Signed-off-by: Jonathan G. Underwood <[email protected]>
Signed-off-by: Jonathan G. Underwood <[email protected]>
Signed-off-by: Jonathan G. Underwood <[email protected]>
Signed-off-by: Jonathan G. Underwood <[email protected]>
jonathanunderwood
force-pushed
the
fixups
branch
from
7fbc9c5
to
6134b4c
Compare
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes fixes the broken
.run()capability, and adds some docstrings and clarifications along the way.This fixes #201 and item 3 in #184.