Fix COMPOSE_PROJECT_NAME interpolation
#1165
Conversation
r10r
changed the title
COMPOSE_PROJECT_NAME interpolation
r10r
force-pushed
the
fix-project-name-interpolation
branch
from
198623d to
6fd5b54
Compare
r10r
changed the title
COMPOSE_PROJECT_NAME interpolationCOMPOSE_PROJECT_NAME interpolation
|
After looking at #805 I noticed that apart from the interpolation the evaluation order is wrong. I'll add a separate commit that addresses this issue including another integration test. |
r10r
changed the title
COMPOSE_PROJECT_NAME interpolationCOMPOSE_PROJECT_NAME interpolation
|
@r10r Thanks for the PR, code changes look good. Please add a release note to the newsfragments directory (you can look here for inspiration on how release note looks like). In this PR I think there are not one but two fixes. |
Thanks for the review. I'll add the release note as soon as possible. |
Refs containers#1073 Signed-off-by: Ruben Jenster <[email protected]>
Fixes containers#1073 Signed-off-by: Ruben Jenster <[email protected]>
…ME env variable Signed-off-by: Ruben Jenster <[email protected]>
The COMPOSE_PROJECT_NAME environment variable must override the top-level name: attribute in the Compose file. The precedence order is defined in the docker compose documentation https://docs.docker.com/compose/how-tos/project-name/#set-a-project-name Signed-off-by: Ruben Jenster <[email protected]>
r10r
force-pushed
the
fix-project-name-interpolation
branch
from
c8f4107 to
65b455f
Compare
|
@p12tic I've added the release notes and moved the section formatted by |
|
Thank you very much |
This fixes the interpolation of the environment variable COMPOSE_PROJECT_NAME
when it is generated from the top-level
namevalue within the compose.yaml.See #1073 and the integration test description for details.
This PR was developed independently from #805 (because I did not look for related open PRs first) but addresses the same issue and contains the required integration test. I think #805 can be closed if this PR is merged.