Add quiet flag to podman-compose config #1152
Merged
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
reviewed
Feb 28, 2025
It's best to expose all user-visible changes. If only so that project appears more active.
Agreed, thanks. Separately, please add signed-off-by line, there's a policy on the containers organization that requires it. More info: https://github.com/containers/podman-compose/pull/1152/checks?check_run_id=37949903107 |
This skips printing and is useful for validating config files. Signed-off-by: Ian Fijolek <[email protected]>
IamTheFij
force-pushed
the
config-quiet
branch
from
3bcb1f3 to
4cd1642
Compare
|
Done! I also created a new PR (#1153) to catch committing without sign-off for future new contributors. Hopefully that bubbles things up earlier to them so you don't have to be the one to tell them on the PR. |
p12tic
approved these changes
Mar 1, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips printing and is useful for validating config files.
This is present in
docker-composeanddocker composeas well: https://docs.docker.com/reference/cli/docker/compose/config/Do you think this warrants news? I could add that, but it seems pretty minor.
Also, since it is testing the print, the unit test didn't make sense. I added an integration test instead.