Don't raise exception on inexistent services in 'down' command #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeffman
force-pushed
the
no_exception_if_service_is_not_in_compose
branch
from
4e7a973 to
cc9faed
Compare
p12tic
reviewed
Jan 30, 2025
|
Looks good. Please also add:
|
When running 'podman-compose down <service>', if service is not part of the compose, a KeyError exception is raised in function 'get_excluded'. By only allowing evaluation of services that exist in the compose provides a cleaner and gentler exit for this case. Signed-off-by: Rafael Guterres Jeffman <[email protected]>
rjeffman
force-pushed
the
no_exception_if_service_is_not_in_compose
branch
from
cc9faed to
d476071
Compare
|
@p12tic sorry for the long delay (work and a needed PTO were in place). I fixed the PR with your requests. Let me know if anything else is needed. |
p12tic
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running 'podman-compose down ', if service is not part of the compose, a KeyError exception was raised it function 'get_excluded'.
By only allowing evaluation of services that exist in the compose provides a cleaner and gentler exit for this case.