Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Introduce priorityClassName system-node-critical #220

Merged
merged 2 commits into from
Jan 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deployment/helm/balloons/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,3 +104,4 @@ customize with their own values, along with the default values.
| `tolerations` | [] | specify taint toleration key, operator and effect |
| `affinity` | [] | specify node affinity |
| `nodeSelector` | [] | specify node selector labels |
| `podPriorityClassNodeCritical` | false | enable [marking Pod as node critical](https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical) |
3 changes: 3 additions & 0 deletions deployment/helm/balloons/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ spec:
mountPath: /var/run/nri-resource-policy
- name: nrisockets
mountPath: /var/run/nri
{{- if .Values.podPriorityClassNodeCritical }}
priorityClassName: system-node-critical
{{- end }}
volumes:
- name: resource-policydata
hostPath:
Expand Down
5 changes: 5 additions & 0 deletions deployment/helm/balloons/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,8 @@ nodeSelector: []
#
# nodeSelector:
# kubernetes.io/disk: "ssd"

# NRI plugins should be considered as part of the container runtime.
# Therefore, adding the system-node-critical priority class to the DaemonSet,
# could mitigate potential risk in a running system under load.
podPriorityClassNodeCritical: false
3 changes: 2 additions & 1 deletion deployment/helm/memory-qos/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,12 @@ customize with their own values, along with the default values.
| `image.tag` | unstable | container image tag |
| `image.pullPolicy` | Always | image pull policy |
| `resources.cpu` | 10m | cpu resources for the Pod |
| `resources.memory` | 100Mi | memory qouta for the |
| `resources.memory` | 100Mi | memory qouta for the Pod |
| `nri.patchRuntimeConfig` | false | enable NRI in containerd or CRI-O |
| `initImage.name` | [ghcr.io/containers/nri-plugins/config-manager](https://ghcr.io/containers/nri-plugins/config-manager) | init container image name |
| `initImage.tag` | unstable | init container image tag |
| `initImage.pullPolicy` | Always | init container image pull policy |
| `tolerations` | [] | specify taint toleration key, operator and effect |
| `affinity` | [] | specify node affinity |
| `nodeSelector` | [] | specify node selector labels |
| `podPriorityClassNodeCritical` | false | enable [marking Pod as node critical](https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical) |
3 changes: 3 additions & 0 deletions deployment/helm/memory-qos/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ spec:
mountPath: /etc/nri/memory-qos
- name: nrisockets
mountPath: /var/run/nri
{{- if .Values.podPriorityClassNodeCritical }}
priorityClassName: system-node-critical
{{- end }}
volumes:
- name: memory-qos-config-vol
configMap:
Expand Down
5 changes: 5 additions & 0 deletions deployment/helm/memory-qos/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,8 @@ nodeSelector: []
#
# nodeSelector:
# kubernetes.io/disk: "ssd"

# NRI plugins should be considered as part of the container runtime.
# Therefore, adding the system-node-critical priority class to the DaemonSet,
# could mitigate potential risk in a running system under load.
podPriorityClassNodeCritical: false
3 changes: 2 additions & 1 deletion deployment/helm/memtierd/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ customize with their own values, along with the default values.
| `image.tag` | unstable | container image tag |
| `image.pullPolicy` | Always | image pull policy |
| `resources.cpu` | 250m | cpu resources for the Pod |
| `resources.memory` | 100Mi | memory qouta for the |
| `resources.memory` | 100Mi | memory qouta for the Pod |
| `outputDir` | empty string | host directory for memtierd.output files |
| `nri.patchRuntimeConfig` | false | enable NRI in containerd or CRI-O |
| `initImage.name` | [ghcr.io/containers/nri-plugins/config-manager](https://ghcr.io/containers/nri-plugins/config-manager) | init container image name |
Expand All @@ -102,3 +102,4 @@ customize with their own values, along with the default values.
| `tolerations` | [] | specify taint toleration key, operator and effect |
| `affinity` | [] | specify node affinity |
| `nodeSelector` | [] | specify node selector labels |
| `podPriorityClassNodeCritical` | false | enable [marking Pod as node critical](https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical) |
3 changes: 3 additions & 0 deletions deployment/helm/memtierd/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ spec:
- name: run-dir-vol
mountPath: /run-dir
{{- end }}
{{- if .Values.podPriorityClassNodeCritical }}
priorityClassName: system-node-critical
{{- end }}
volumes:
- name: memtierd-config-vol
configMap:
Expand Down
5 changes: 5 additions & 0 deletions deployment/helm/memtierd/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,8 @@ nodeSelector: []
#
# nodeSelector:
# kubernetes.io/disk: "ssd"

# NRI plugins should be considered as part of the container runtime.
# Therefore, adding the system-node-critical priority class to the DaemonSet,
# could mitigate potential risk in a running system under load.
podPriorityClassNodeCritical: false
6 changes: 4 additions & 2 deletions deployment/helm/sgx-epc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,13 @@ customize with their own values, along with the default values.
| `image.tag` | unstable | container image tag |
| `image.pullPolicy` | Always | image pull policy |
| `resources.cpu` | 25m | cpu resources for the Pod |
| `resources.memory` | 100Mi | memory qouta for the |
| `resources.memory` | 100Mi | memory qouta for the Pod |
| `nri.patchRuntimeConfig` | false | enable NRI in containerd or CRI-O |
| `initImage.name` | [ghcr.io/containers/nri-plugins/config-manager](https://ghcr.io/containers/nri-plugins/config-manager) | init container image name |
| `initImage.name` | [ghcr.io/containers/nri-plugins/config-manager](https://ghcr.io/containers/nri-plugins/config-manager) |
| init container image name |
| `initImage.tag` | unstable | init container image tag |
| `initImage.pullPolicy` | Always | init container image pull policy |
| `tolerations` | [] | specify taint toleration key, operator and effect |
| `affinity` | [] | specify node affinity |
| `nodeSelector` | [] | specify node selector labels |
| `podPriorityClassNodeCritical` | false | enable [marking Pod as node critical](https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical) |
3 changes: 3 additions & 0 deletions deployment/helm/sgx-epc/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ spec:
volumeMounts:
- name: nrisockets
mountPath: /var/run/nri
{{- if .Values.podPriorityClassNodeCritical }}
priorityClassName: system-node-critical
{{- end }}
volumes:
- name: nrisockets
hostPath:
Expand Down
5 changes: 5 additions & 0 deletions deployment/helm/sgx-epc/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,8 @@ nodeSelector: []
#
# nodeSelector:
# kubernetes.io/disk: "ssd"

# NRI plugins should be considered as part of the container runtime.
# Therefore, adding the system-node-critical priority class to the DaemonSet,
# could mitigate potential risk in a running system under load.
podPriorityClassNodeCritical: false
1 change: 1 addition & 0 deletions deployment/helm/template/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,4 @@ customize with their own values, along with the default values.
| `initImage.tag` | unstable | init container image tag |
| `initImage.pullPolicy` | Always | init container image pull policy |
| `tolerations` | [] | specify taint toleration key, operator and effect |
| `podPriorityClassNodeCritical` | false | enable [marking Pod as node critical](https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical) |
3 changes: 3 additions & 0 deletions deployment/helm/template/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ spec:
mountPath: /var/run/nri-resource-policy
- name: nrisockets
mountPath: /var/run/nri
{{- if .Values.podPriorityClassNodeCritical }}
priorityClassName: system-node-critical
{{- end }}
volumes:
- name: resource-policydata
hostPath:
Expand Down
5 changes: 5 additions & 0 deletions deployment/helm/template/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,8 @@ tolerations: []
# - key: "node-role.kubernetes.io/control-plane"
# operator: "Exists"
# effect: "NoSchedule"

# NRI plugins should be considered as part of the container runtime.
# Therefore, adding the system-node-critical priority class to the DaemonSet,
# could mitigate potential risk in a running system under load.
podPriorityClassNodeCritical: false
1 change: 1 addition & 0 deletions deployment/helm/topology-aware/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,4 @@ customize with their own values, along with the default values.
| `tolerations` | [] | specify taint toleration key, operator and effect |
| `affinity` | [] | specify node affinity |
| `nodeSelector` | [] | specify node selector labels |
| `podPriorityClassNodeCritical` | false | enable [marking Pod as node critical](https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical) |
3 changes: 3 additions & 0 deletions deployment/helm/topology-aware/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ spec:
mountPath: /var/run/nri-resource-policy
- name: nrisockets
mountPath: /var/run/nri
{{- if .Values.podPriorityClassNodeCritical }}
priorityClassName: system-node-critical
{{- end }}
volumes:
- name: resource-policydata
hostPath:
Expand Down
6 changes: 5 additions & 1 deletion deployment/helm/topology-aware/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ resources:
nri:
patchRuntimeConfig: false


initContainerImage:
name: ghcr.io/containers/nri-plugins/nri-config-manager
# If not defined Chart.AppVersion will be used
Expand Down Expand Up @@ -67,3 +66,8 @@ nodeSelector: []
#
# nodeSelector:
# kubernetes.io/disk: "ssd"

# NRI plugins should be considered as part of the container runtime.
# Therefore, adding the system-node-critical priority class to the DaemonSet,
# could mitigate potential risk in a running system under load.
podPriorityClassNodeCritical: false