Fix clang17++ compilation #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne Cordonnier <[email protected]>
- Most implementations of __str__() use invalid syntax (passing self explicitly as first parameter of __repr__() is not valid python syntax since __repr__ does not take an explicit parameter).
For instance "print("schema_info: %s", schema_info)" triggers an error: "TypeError: SchemaInfo.__repr__() takes 1 positional argument but 2 were given"
- There is no reason to explicitly call __repr__() from __str__(), since this is the default python behavior
Signed-off-by: Etienne Cordonnier <[email protected]>
ocispec/runtime_spec_schema_config_schema.h contains the following code which uses the reserved c++ keyword "class":
typedef struct {
char *class;
int32_t priority;
yajl_val _residual;
unsigned int priority_present : 1;
}
Thus the code fails to compile with clang++ 17.
Fixes containers#132 ( containers#132 )
Signed-off-by: Etienne Cordonnier <[email protected]>
|
I'm late but LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix compilation error with clang++17
ocispec/runtime_spec_schema_config_schema.h contains the following code which uses the reserved c++ keyword "class":
typedef struct {
char *class;
int32_t priority;
yajl_val _residual;
unsigned int priority_present : 1;
}
Thus the code fails to compile with clang++ 17.
Fixes #132 ( #132 )