feat: add support for PVH boot protocol #284
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both krunfw + virtio-blk and external kernel (with support) + virtio-fs are valid scenarios, so reduce the amount of code
Confirm kernel is running when console doesn't work To test: ./chroot_vm --kernel-cmdline='"console=com root=ld0a"' --loglevel=7 --kernel-format=1 --kernel /tmp/netbsd-SMOL --boot-disk /tmp/rescue-amd64-ro.img
|
Do you want us to start reviewing this PR or do you prefer us to wait for the clean up? |
|
I'm okay with you reviewing it currently. What's left: propagate Linux/PVH boot mode switch to all these places, fix and extend tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP support for PVH boot, enabling e.g. smolBSD to boot.
Parts copied from: