Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demote WARN log to DEBUG #266

Merged
merged 1 commit into from
Feb 12, 2025
Merged

demote WARN log to DEBUG #266

merged 1 commit into from
Feb 12, 2025

Conversation

jakecorrenti
Copy link
Member

@jakecorrenti
demote WARN log to DEBUG
e302830 
Signed-off-by: Jake Correnti <[email protected]>
@jakecorrenti
Copy link
Member Author

I checked the other warn!() messages but they use terminology like "invalid" or "unknown" so I couldn't tell if those should stay elevated or not.

tylerfanelli
tylerfanelli approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@tylerfanelli tylerfanelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think you can leave the other warn! messages.

slp
slp approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@slp slp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakecorrenti !

@slp slp merged commit a84dc1a into containers:main Feb 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slp slp slp approved these changes

@tylerfanelli tylerfanelli tylerfanelli approved these changes

@MatiasVara MatiasVara Awaiting requested review from MatiasVara MatiasVara is a code owner

@mtjhrc mtjhrc Awaiting requested review from mtjhrc mtjhrc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakecorrenti @slp @tylerfanelli