Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Intel Trust Domain Extensions (TDX) #228

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

jakecorrenti
Copy link
Member

@jakecorrenti jakecorrenti commented Oct 21, 2024

This PR adds support for the Intel Trust Domain Extensions (TDX) Confidential Computing architecture.

This is currently a draft as the following issues are present:

  • The guest is failing to complete the boot sequence. I suspect this is due to firmware issues, such as a lack of proper IDT setup and #VE handling
  • https://www.github.com/virtee/tdx needs to get published to crates.io before this can get merged

Before merging there are some commits that will be squashed and/or re-ordered.

There is also additional functionality that I would like to add such as:

  • Comprehensive CPUID configuration based off of the TDX capabilities reported by KVM_TDX_CAPABILITIES
  • Handle the following VMCALLs
    • TDG.VP.VMCALL<SetupEventNotifyInterrupt>
    • TDG.VP.VMCALL<GetQuote>
    • TDG.VP.VMCALL<MapGPA>
    • TDG.VP.VMCALL<REPORT_FATAL_ERROR>
  • Validate TDX Attributes when reported by KVM_TDX_CAPABILITIES
  • Update README.md and other docs
  • Make sure guests work with varying memory and vCPU configurations

Any early reviews are welcome.

@jakecorrenti
Copy link
Member Author

Temporarily pushing a mess of commits so that it can get cleaned up...

Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
In `memory_init` we need to use `kvm_userspace_memory_region2`,
`kvm_create_guest_memfd`, and `kvm_memory_attributes` for the TDX
architecture, otherwise it will fail.

Signed-off-by: Jake Correnti <[email protected]>
TDX does not use the `KVM_CREATE_IRQCHIP` ioctl, rather it enables the
`KVM_SPLIT_IRQCHIP` capability, which is handled by virtee/tdx.

Signed-off-by: Jake Correnti <[email protected]>
Registers are confidential for TDX, so configuring them through the KVM
API is not allowed.

Signed-off-by: Jake Correnti <[email protected]>
Adds a new `inteltdx` module and implements a feature-flagged `new`
method for `VM to create a VM with the TDX architecure.

Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
Implements the `tdx_secure_virt_prepare` method which
in turn calls the `KVM_TDX_INIT_VM` TDX ioctl which does VM specific
initialization.

Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
…rt the memory page accordingly

Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant