Refactor argument parsing using newer clap derive #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtjhrc
changed the title
mtjhrc
force-pushed
the
refactor-clap
branch
5 times, most recently
from
8bfe055 to
d959d0d
Compare
Signed-off-by: Matej Hrica <[email protected]>
This seems to catch more problems, such as the u8/i8 mismatch on aarch64 platforms. Signed-off-by: Matej Hrica <[email protected]>
We need #[allow(unused_mut)], to disable warnings on other targets. Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
You could have a trait and uniform interface for the run method, but it isn't necessary for now. It also allows passing more arguments from main. Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
slp
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seem like closes issue/suggestion #43, but not sure what was meant by it.
I found some not implemented arguments, for now I left it the way it was before and left TODOs.