Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/containers/storage to v1.48.1 #2094

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 22, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/containers/storage require patch v1.48.1-0.20230728131509-c3da76fa3f63 -> v1.48.1

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Aug 22, 2023
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a downgrade from a mainline commit; let‘s wait for containers/storage#1691 so that mainline is a superset of 1.48.1 , then update to that commit instead.

@rhatdan rhatdan closed this Aug 22, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Aug 22, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (v1.48.1). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/github.com-containers-storage-1.x branch August 22, 2023 14:27
@mtrmac
Copy link
Collaborator

mtrmac commented Aug 22, 2023

@rhatdan I wanted to keep this open to track the need to update c/storage mainline. Oh well, Renovate will file a PR in a month.

@rhatdan
Copy link
Member

rhatdan commented Aug 22, 2023

I think we should probably just cut a new storage update for main branch to keep this moving forward.

@mtrmac
Copy link
Collaborator

mtrmac commented Aug 22, 2023

Alternatively, merge the release branch into main, like #2070 — but users of c/storage would still need to manually update to the post-merge commit.

@rhatdan
Copy link
Member

rhatdan commented Aug 22, 2023

I cut v1.49.0 which will move forward with the correct updates. I has been almost two months since it was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants