Build-Push: Install pip and wait-for-copr

[lsm5]

Podman-Desktop team would like fcos images built with packages from rhcontainerbot/podman-next for MacOS testing with the latest unreleased bits.
Ref: containers/podman#19477

This commit installs pip and wait-for-copr in the build-push images. wait-for-copr, as the name suggests, waits for a build with a specified string to become available on a copr repo.
Ref: https://github.com/packit/wait-for-copr

[cevich]

LGTM

[cevich]

oh, you need to make IMG_SFX and add that file too. Otherwise validate will fail.

[lsm5]

oh, you need to make IMG_SFX and add that file too. Otherwise validate will fail.

done.

[cevich]

Ooooo, spotted a problem (glad I looked at the build log):

    build-push: 
  WARNING: The script wait-for-copr is installed in '/home/packer/.local/bin' which is not on PATH.
    build-push:   Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.

I think maybe stick a $SUDO in front of the pip3 and that should stick it somewhere more generally usable?

[cevich]

oh, and you'll want to rebase since I just merged a PR.

[github-actions]

Cirrus CI build successful. Found built image names and IDs:

Stage	Image Name	IMAGE_SUFFIX
base	debian	b20230810t201257z-f38f37d13
base	fedora	b20230810t201257z-f38f37d13
base	fedora-aws	b20230810t201257z-f38f37d13
base	fedora-aws-arm64	b20230810t201257z-f38f37d13
base	image-builder	b20230810t201257z-f38f37d13
base	prior-fedora	b20230810t201257z-f38f37d13
cache	build-push	c20230810t201257z-f38f37d13
cache	debian	c20230810t201257z-f38f37d13
cache	fedora	c20230810t201257z-f38f37d13
cache	fedora-aws	c20230810t201257z-f38f37d13
cache	fedora-netavark	c20230810t201257z-f38f37d13
cache	fedora-netavark-aws-arm64	c20230810t201257z-f38f37d13
cache	fedora-podman-aws-arm64	c20230810t201257z-f38f37d13
cache	fedora-podman-py	c20230810t201257z-f38f37d13
cache	prior-fedora	c20230810t201257z-f38f37d13
cache	rawhide	c20230810t201257z-f38f37d13
cache	win-server-wsl	c20230810t201257z-f38f37d13

[cevich]

LGTM. Maybe try this out in your podman PR, then if the image is okay, just go ahead and merge this.

One (maybe) minor thing of note (in case anybody goes hunting through PRs), I don't remember seeing this before (I could be mistaken):

    build-push: 
The unit files have no installation config (WantedBy=, RequiredBy=, Also=,
    build-push: 
Alias= settings in the [Install] section, and DefaultInstance= for template
    build-push: 
units). This means they are not meant to be enabled or disabled using systemctl.
    build-push: 
 
    build-push: 
Possible reasons for having this kind of units are:
    build-push: 
• A unit may be statically enabled by being symlinked from another unit's
    build-push: 
  .wants/ or .requires/ directory.
    build-push: 
• A unit's purpose may be to act as a helper for some other unit which has
    build-push: 
  a requirement dependency on it.
    build-push: 
• A unit may be started when needed via activation (socket, path, timer,
    build-push: 
  D-Bus, udev, scripted systemctl call, ...).
    build-push: 
• In case of template units, the unit is meant to be enabled with some
    build-push: 
  instance name specified.

[cevich]

Note: This is going to conflict w/ #286 over the IMG_SFX contents (assuming #286 merges first).

[lsm5]

Note: This is going to conflict w/ #286 over the IMG_SFX contents (assuming #286 merges first).

no worries. I can rebase.

[cevich]

Oof, need one more rebase.

[cevich]

Clarification: Rebase + run make IMG_SFX again (and commit).

[cevich]

Commit moved into #294