renovate: update to go 1.22 #227
Conversation
Podman no longer uses CI:DOCS as it skips based on source changes. As such this title doesn't add anything besides confusion why it is there. Signed-off-by: Paul Holzinger <[email protected]>
We have pinned the renovate go version to the lowest version we support as otherwise it will create PRs that update to new go version which we always want to take care of manually as it included more changes usually. While it doesn't prevent renovate from creating these PRs they always fail as it cannot update to a newer go version so it is clear to reviewers what is going on. Signed-off-by: Paul Holzinger <[email protected]>
|
cc @mtrmac |
This test doesn't wotk when run before 1pm UTC only after, we could add a +24 hours but it is not clear what the purpose of this function is so just remove it. We know that timebomb seems to work good enough in practice and regressions are unlikely. Signed-off-by: Paul Holzinger <[email protected]>
@mtrmac Did the exit code of skopeo change at some point? I see exit code 2 also locally when inspecting this image so I guess I should just fix the test? |
Found it containers/skopeo@16b6f0a so I update the test here, not sure why this worked for so long but all of the sudden things start to break when I open a PR:( |
A change[1] in skope made it exit with 2 if the image is not found so fix the test assumption here. [1] containers/skopeo@16b6f0a Signed-off-by: Paul Holzinger <[email protected]>
|
Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's cc18e81abf8367b33b4e4d47da6c761d18c94c42. |
|
So I think this is only waiting for the c/image PR to be merged and someone bumping storage? Are you planning to do this @mtrmac? |
|
I have now filed containers/storage#2086 for c/storage. I think that’s all the repos we immediately care about. |
Our renovate config does not yet support go 1.22[1] so do it manually for now. [1] containers/automation#227 Signed-off-by: Paul Holzinger <[email protected]>
|
All projects have been updated, this can be merged. Who has the rights to do so? @edsantiago maybe? |
|
I see a big green Merge button and will see what happens if I push it. |
|
Thanks! For the record, containers/skopeo#2418 now correctly creates dependency update PRs. |
|
… containers/skopeo#2418 shows Renovate now correctly creates dependency update PRs. |
We have pinned the renovate go version to the lowest version we support
as otherwise it will create PRs that update to new go version which we
always want to take care of manually as it included more changes
usually. While it doesn't prevent renovate from creating these PRs they
always fail as it cannot update to a newer go version so it is clear to
reviewers what is going on.