-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation updates #828
Conversation
|
Do the Vulkan builds still need to be disabled? |
Please remove and update your repo, vulkan was just updated. |
nope, removed it - I was hoping someone else would fix the vulkan build and they did :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally /LGTM. Just once nitpicky comment but everything looks fine. That being said I havent tested any of this
cd ../../models | ||
make download-model-granite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of these are technically correct, what you have and what I had previously. This is because I have an override command in the makefile which will call that make command in models. You can change this if you want but I think it is more correct to use the override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not notice that in the llamacpp_python/Makefile, updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes in this PR are unrelated to the purpose explained in the title so it should be splitted into 2 different PRs for better readability
Signed-off-by: sallyom <[email protected]>
@jeffmaury ptal - this PR is now only documentation updates. The rag/app/manage_vectordb.py import update I'll open in #838. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A few cleanup items and updating RAG README for running with milvus.
@rhatdan @MichaelClifford