Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #828

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Documentation updates #828

merged 1 commit into from
Jan 7, 2025

Conversation

sallyom
Copy link
Collaborator

@sallyom sallyom commented Dec 3, 2024

A few cleanup items and updating RAG README for running with milvus.

@rhatdan @MichaelClifford

@sallyom
Copy link
Collaborator Author

sallyom commented Dec 3, 2024

this PR disables vulkan image builds: #829
removed that commit

@rhatdan
Copy link
Member

rhatdan commented Dec 4, 2024

Do the Vulkan builds still need to be disabled?

@rhatdan
Copy link
Member

rhatdan commented Dec 4, 2024

Please remove and update your repo, vulkan was just updated.

@sallyom
Copy link
Collaborator Author

sallyom commented Dec 5, 2024

Do the Vulkan builds still need to be disabled?

nope, removed it - I was hoping someone else would fix the vulkan build and they did :)

Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally /LGTM. Just once nitpicky comment but everything looks fine. That being said I havent tested any of this

cd ../../models
make download-model-granite
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these are technically correct, what you have and what I had previously. This is because I have an override command in the makefile which will call that make command in models. You can change this if you want but I think it is more correct to use the override.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not notice that in the llamacpp_python/Makefile, updated!

Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes in this PR are unrelated to the purpose explained in the title so it should be splitted into 2 different PRs for better readability

@sallyom
Copy link
Collaborator Author

sallyom commented Jan 6, 2025

@jeffmaury ptal - this PR is now only documentation updates. The rag/app/manage_vectordb.py import update I'll open in #838.

@sallyom sallyom changed the title rag-milvus Documentation updates Jan 6, 2025
Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 92ef41d into containers:main Jan 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants