Skip to content

[WIP]Fix CNI plugin to care DNS changes in latest CNI #1172

[WIP]Fix CNI plugin to care DNS changes in latest CNI

[WIP]Fix CNI plugin to care DNS changes in latest CNI #1172

Triggered via pull request October 26, 2023 08:28
Status Failure
Total duration 1m 2s
Artifacts

test.yaml

on: pull_request
Build all linux architectures
0s
Build all linux architectures
Run tests on Linux amd64
0s
Run tests on Linux amd64
Build and run tests on Windows
0s
Build and run tests on Windows
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 4 warnings
Lint: plugins/ipam/host-local/dns.go#L1
: # github.com/containernetworking/plugins/plugins/ipam/host-local [github.com/containernetworking/plugins/plugins/ipam/host-local.test]
Lint: plugins/ipam/host-local/main.go#L70
cannot use dns (variable of type *"github.com/containernetworking/cni/pkg/types".DNS) as "github.com/containernetworking/cni/pkg/types".DNS value in assignment (typecheck)
Lint: plugins/ipam/static/main.go#L1
: # github.com/containernetworking/plugins/plugins/ipam/static [github.com/containernetworking/plugins/plugins/ipam/static.test]
Lint: plugins/ipam/static/main.go#L266
cannot use &ipamConf.DNS (value of type *"github.com/containernetworking/cni/pkg/types".DNS) as "github.com/containernetworking/cni/pkg/types".DNS value in struct literal (typecheck)
Lint: plugins/main/bridge/bridge.go#L1
: # github.com/containernetworking/plugins/plugins/main/bridge [github.com/containernetworking/plugins/plugins/main/bridge.test]
Lint: plugins/main/bridge/bridge.go#L737
invalid operation: n.DNS != nil (mismatched types "github.com/containernetworking/cni/pkg/types".DNS and untyped nil) (typecheck)
Lint: plugins/main/ptp/ptp.go#L1
: # github.com/containernetworking/plugins/plugins/main/ptp [github.com/containernetworking/plugins/plugins/main/ptp.test]
Lint: plugins/main/ptp/ptp.go#L244
invalid operation: conf.DNS != nil (mismatched types "github.com/containernetworking/cni/pkg/types".DNS and untyped nil) (typecheck)
Lint: pkg/ns/ns_linux_test.go#L185
ginkgo-linter: use Equal with different types: Comparing uint64 with int; either change the expected value type if possible, or use the BeEquivalentTo() matcher, instead of Equal() (ginkgolinter)
Lint
issues found
Lint: plugins/ipam/host-local/backend/disk/disk_suite_test.go#L20
dot-imports: should not use dot imports (revive)
Lint: plugins/ipam/host-local/backend/disk/disk_suite_test.go#L21
dot-imports: should not use dot imports (revive)
Lint: plugins/ipam/host-local/backend/disk/lock_test.go#L21
dot-imports: should not use dot imports (revive)
Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/plugins/plugins. Supported file pattern: go.sum