Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruiwen-zhao's email #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update ruiwen-zhao's email #128

wants to merge 1 commit into from

Conversation

ruiwen-zhao
Copy link
Member

Update ruiwen-zhao's email

@samuelkarp
Copy link
Member

Can you git commit --amend -s so the commit gets the Signed-off-by line? That's what's causing the presubmit to fail.

mikebrow
mikebrow approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@AkihiroSuda
Copy link
Member

ping @ruiwen-zhao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikebrow mikebrow mikebrow approved these changes

@samuelkarp samuelkarp Awaiting requested review from samuelkarp

Assignees

@ruiwen-zhao ruiwen-zhao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruiwen-zhao @samuelkarp @AkihiroSuda @mikebrow